Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve internals of inliner #1539

Open
veripoolbot opened this issue Oct 6, 2019 · 2 comments
Open

Improve internals of inliner #1539

veripoolbot opened this issue Oct 6, 2019 · 2 comments
Labels
area: performance Issue involves performance issues effort: days Expect this issue to require roughly days of invested effort to resolve type: feature-IEEE Request to add new feature, described in IEEE 1800 type: feature-non-IEEE Request to add new feature, outside IEEE 1800 type: maintenance Internal maintenance task

Comments

@veripoolbot
Copy link
Contributor

Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1539 from https://www.veripool.org

Feature tracking bug.

The current module inliner code works by operating on modules before the complete scoped hierarchy has been created (V3Scope).

This should be changed to be post-scope, as this would also remove the horrible need to go through V3LinkDot for the final time to cleanup inlined references. This V3LinkDot pass is very difficult to maintain.

Some work was started on this about a year ago and is incomplete.
@veripoolbot veripoolbot added area: performance Issue involves performance issues effort: days Expect this issue to require roughly days of invested effort to resolve type: feature-IEEE Request to add new feature, described in IEEE 1800 type: feature-non-IEEE Request to add new feature, outside IEEE 1800 type: maintenance Internal maintenance task labels Dec 22, 2019
@wsnyder wsnyder mentioned this issue Apr 5, 2020
Open
@wsnyder wsnyder mentioned this issue Dec 6, 2020
Open
@wsnyder wsnyder mentioned this issue Jan 10, 2021
Closed
@gezalore
Copy link
Member

@wsnyder is this still expected to happen? I was planning to make some improvements in the current inline pass, but this makes me wonder if it's futile.

@wsnyder
Copy link
Member

wsnyder commented Dec 21, 2021

This stalled out in a branch as interfaces proved a big mess (as usual). If you have improvements, perhaps short of a big rewrite, feel free to put them in, and if/when I get back to this I'll port the changes to the new version. If you're interested in doing something major I can put what I have onto a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: performance Issue involves performance issues effort: days Expect this issue to require roughly days of invested effort to resolve type: feature-IEEE Request to add new feature, described in IEEE 1800 type: feature-non-IEEE Request to add new feature, outside IEEE 1800 type: maintenance Internal maintenance task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wsnyder @gezalore @veripoolbot