Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unpacked structs #1541

Closed
veripoolbot opened this issue Oct 6, 2019 · 5 comments
Closed

Support unpacked structs #1541

veripoolbot opened this issue Oct 6, 2019 · 5 comments
Labels
area: data-types Issue involves data-types effort: weeks Expect this issue to require weeks or more of invested effort to resolve resolution: fixed Closed; fixed type: feature-IEEE Request to add new feature, described in IEEE 1800

Comments

@veripoolbot
Copy link
Contributor


Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1541 from https://www.veripool.org


Feature tracking bug.

As a step towards class support (#�), support unpacked structures.

@veripoolbot veripoolbot added area: data-types Issue involves data-types effort: weeks Expect this issue to require weeks or more of invested effort to resolve type: feature-IEEE Request to add new feature, described in IEEE 1800 labels Dec 22, 2019
@kaddkaka
Copy link

kaddkaka commented Jun 1, 2020

The current lint error when dealing with this is a bit misleading. The following code

module test_module();
struct {
        logic [1:0] a[2:0];
} a_struct;
endmodule

Results in this lint-error:

verilator --lint-only test.v
%Error: test.v:5:22: Unsupported: Unpacked array in packed struct/union
    5 |         logic [1:0] a[2:0];
      |                      ^
%Error: Exiting due to 1 error(s)

Since the code should actually result in an unpacked struct, there would be good with a note that this is not supported in verilator yet.

@wsnyder
Copy link
Member

wsnyder commented Jun 1, 2020

Um, it says "Unsupported" right in the message. So, I'm not sure what you are suggesting.

@kaddkaka
Copy link

kaddkaka commented Jun 2, 2020 via email

@wsnyder
Copy link
Member

wsnyder commented Jun 2, 2020

Makes sense, fixed error and now refers to UNPACKED error in the manual.

@wsnyder
Copy link
Member

wsnyder commented Dec 21, 2022

Fixed with #3802

@wsnyder wsnyder closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: data-types Issue involves data-types effort: weeks Expect this issue to require weeks or more of invested effort to resolve resolution: fixed Closed; fixed type: feature-IEEE Request to add new feature, described in IEEE 1800
Projects
None yet
Development

No branches or pull requests

3 participants