Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $countbits (starter task) #1639

Closed
veripoolbot opened this issue Dec 15, 2019 · 4 comments
Closed

Support $countbits (starter task) #1639

veripoolbot opened this issue Dec 15, 2019 · 4 comments
Assignees
@ynivin
Labels
effort: hours Expect this issue to require roughly hours of invested effort to resolve resolution: fixed Closed; fixed type: feature-IEEE Request to add new feature, described in IEEE 1800

Comments

@veripoolbot
Copy link
Contributor

Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1639 from https://www.veripool.org

Good starter task is to implement and test $countbits, which is a generation of $countones etc.

The existing $countones functions inside V3Number could be removed to use the new generic countbits. The runtime functions in verilated.h should remain specialized, as that will help performance.
@veripoolbot veripoolbot added effort: hours Expect this issue to require roughly hours of invested effort to resolve good first issue Good for newcomers status: ready Issue is ready for someone to fix; then goes to 'status: assigned' type: feature-IEEE Request to add new feature, described in IEEE 1800 labels Dec 22, 2019
@ynivin
Copy link
Contributor

ynivin commented Jan 11, 2020

I'm currently working on implementation for this here: https://github.com/ynivin/verilator/tree/issue-1639
I would create PR once I have something working.

@wsnyder wsnyder added status: assigned Issue is assigned to someone to work on and removed status: ready Issue is ready for someone to fix; then goes to 'status: assigned' labels Jan 12, 2020
@wsnyder
Copy link
Member

wsnyder commented Mar 1, 2020

How is this going? Need a review or other assistance?

@ynivin
Copy link
Contributor

ynivin commented Mar 1, 2020

How is this going? Need a review or other assistance?

I had some very busy months and didn't have the chance to complete it yet.
I plan to work on it in the next few weeks.

@wsnyder wsnyder added resolution: fixed Closed; fixed and removed good first issue Good for newcomers status: assigned Issue is assigned to someone to work on labels May 10, 2020
@wsnyder
Copy link
Member

wsnyder commented May 10, 2020

Merged with #2287. Thanks for your work on this.

@wsnyder wsnyder closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ynivin ynivin

Labels
effort: hours Expect this issue to require roughly hours of invested effort to resolve resolution: fixed Closed; fixed type: feature-IEEE Request to add new feature, described in IEEE 1800
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wsnyder @ynivin @veripoolbot