Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-15T19:46:38Z

If you could take a look that would be great.

Run with --debug and look at the tree file to check the expression, in verilog.y you'll see y_IFF ("iff") becomes an argument to AstPslClocked. This is then expanded in V3AssertPre, probably that's where the problem is.

In your patch please update a test_regress test to show the issue, add your name to docs/CONTRIBUTORS and use indicate your email address for the commit (or if you prefer point me to a github branch with the change).

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-17T11:12:21Z

Note some assertion bug fixes were recently committed, so might want to pull from master when looking at this.

Original Redmine Comment
Author Name: Peter Monsson
Original Date: 2019-12-20T20:04:22Z

I have updated to the newest master and created a patch with testcases. I hope that this is sufficient. Please let me know what is missing.

I have run regression on the t_assert_property*.pl tests. Is there a way to have a small list of tests to run? The full regression is a bit too slow on my notebook.

Best Regards
Peter

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-20T22:44:27Z

Seems reasonable, thanks for looking into a patch. The only test I see failing you should look at is t_assert_cover. It's possible the test was bad and needs updating.

Also please rename _fails_1.pl to _bad_1.pl (we use _bad for failing tests).

If you think you'll be making other changes, please consider making a github account and send your github username & associated email address so the commit log will be correct.

Original Redmine Comment
Author Name: Peter Monsson
Original Date: 2019-12-21T11:05:10Z

Ahh, I see.

         blockp = new AstAnd(nodep->disablep()->fileline(),
                             new AstNot(nodep->disablep()->fileline(),
                                        nodep->disablep()->unlinkFrBack()),
                             blockp);

Works for cover, but not assert.

         blockp = new AstOr(nodep->disablep()->fileline(),
                            nodep->disablep()->unlinkFrBack(),
                            blockp);

Works for assert, but not cover.

         blockp = new AstIf(nodep->disablep()->fileline(),
                            new AstLogNot(nodep->disablep()->fileline(),
                                          nodep->disablep()->unlinkFrBack()),
                            blockp);

Gives me a V3Clean.cpp:111 internal error.

I am not sure hoe to fix this. I can look at the parent type to see if it is a cover or assert?

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-21T12:48:29Z

I can look at the parent type to see if it is a cover or assert?

It looks like "iff" disables the action, which means don't throw an assert, or don't collect coverage. Currently "true" in the code means assert is ok, or collect coverage, so yes, I think you'd need to look at the parent type.

I'll take that patch, though note I'm not sure if this is the right thing to do long term or invert the true/false terms for the assert.

An update got lost in the bug migration:

Issue #1640 has been updated by Peter Monsson. File issue_1640.patch added I have updated the patch to handle cover and assertion properties. The old behavior stays for cover properties. The new behavior is for everything else.

Thanks Peter, code pushed to git.

Thank you, for helping me out with my first bugfix. Happy to help.