Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A header is missing in V3Width.h #1652

Closed
veripoolbot opened this issue Dec 20, 2019 · 2 comments
Closed

A header is missing in V3Width.h #1652

veripoolbot opened this issue Dec 20, 2019 · 2 comments
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Kuba Ober
Original Redmine Issue: 1652 from https://www.veripool.org

Original Assignee: Kuba Ober

It uses std::min & std::max but doesn't include . This makes the build fail on Windows with platform headers (non-mingw).

Fixed in https://github.com/KubaO/verilator/tree/feature/add-missing-header
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Kuba Ober
Original Date: 2019-12-21T00:38:50Z

This is also #8

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-21T01:15:29Z

Thanks for the good fix, merged towards 4.026.

@veripoolbot veripoolbot added area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed labels Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veripoolbot