Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirent is missing on Windows #1653

Closed
veripoolbot opened this issue Dec 20, 2019 · 3 comments
Closed

dirent is missing on Windows #1653

veripoolbot opened this issue Dec 20, 2019 · 3 comments
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: duplicate Closed; issue or pull request already exists

Comments

@veripoolbot
Copy link
Contributor


Author Name: Kuba Ober
Original Redmine Issue: 1653 from https://www.veripool.org

Original Assignee: Kuba Ober


In the pursuit of a Windows build with minimal changes to the source, I figure it's easiest to use https://github.com/tronkko/dirent.git as a submodule instead of having to maintain some local workaround. I propose adding this submodule to a new folder thirdparty/dirent.

This change won't affect anything else by itself, but then a reference can be added to makefiles or other build scripts to take advantage of it.

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-21T01:14:17Z


Adding submodules increases the friction as we have a lot of users that are git novices, so at this time I would prefer not to go that route.

Presumably there's some smaller fix? Alternatively maybe disable using the dirent stuff, given it's just a performance enhancement?

@veripoolbot veripoolbot added the area: configure/compiling Issue involves configuring or compilating Verilator itself label Dec 22, 2019
@KubaO
Copy link
Contributor

KubaO commented Dec 23, 2019

This one should be closed.

@wsnyder wsnyder added the resolution: duplicate Closed; issue or pull request already exists label Dec 23, 2019
@wsnyder
Copy link
Member

wsnyder commented Dec 23, 2019

Per @KubaO - Will be part of other Windows fixes.

@wsnyder wsnyder closed this as completed Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: duplicate Closed; issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants